Re: libpq WSACleanup is not needed

On 1/16/09, Magnus Hagander <magnus@hagander.net> wrote:
> Andrew Chernow wrote:
>  > WSACleanup is not really needed during a PQfinish.  Its horribly slow if
>  >  the library ref count is 0 and it actually unloads the winsock library,
>  > adds 225ms to PQfinish.
>
> Option A will make us leak the reference to it though, won't it? And we
>  are supposed to clean up after ourselves...
>
>  If you want to override this behavior today, you can just call
>  WSAStartup() in your application, and it should never happen. Right?
>
>  Now, if we actually had libpq_init()/uninit() or something like it, it
>  would make sense to move it there. But I'm not sure we want to just leak
>  the reference. But I'm not entirely convinced either way :-)

I think init/uninit is the answer.  While writing libpqtypes, we noted
that libpq is just plain awkward in a few different ways and probably
deserves a rewrite at some point.  not today though....

merlin