Re: jsonapi type fixups

On 2024-06-20 Th 8:05 AM, Andrew Dunstan wrote:
>
> On 2024-06-18 Tu 7:48 AM, Peter Eisentraut wrote:
>> I have this patch series that fixes up the types of the new 
>> incremental JSON API a bit.  Specifically, it uses "const" throughout 
>> so that the top-level entry points such as 
>> pg_parse_json_incremental() can declare their arguments as const char 
>> * instead of just char *.  This just works, it doesn't require any 
>> new casting tricks.  In fact, it removes a few unconstify() calls.
>>
>> Also, a few arguments and variables that relate to object sizes 
>> should be size_t rather than int.  At this point, this mainly makes 
>> the API better self-documenting.  I don't think it actually works to 
>> parse larger than 2 GB chunks (not tested).
>
>
>
> I think this is mostly OK.
>
> The change at line 1857 of jsonapi.c looks dubious, though. The 
> pointer variable p looks anything but constant. Perhaps I'm 
> misunderstanding.


Ignore this comment, moment of brain fade. Of course it's the string 
that's constant, not the pointer.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com