On Mon, Mar 25, 2024, at 8:55 AM, Peter Eisentraut wrote:
On 22.03.24 04:31, Euler Taveira wrote:
> On Thu, Mar 21, 2024, at 6:49 AM, Shlok Kyal wrote:
>> There is a compilation error while building postgres with the patch
>> due to a recent commit. I have attached a top-up patch v32-0003 to
>> resolve this compilation error.
>> I have not updated the version of the patch as I have not made any
>> change in v32-0001 and v32-0002 patch.
>
> I'm attaching a new version (v33) to incorporate this fix (v32-0003)
> into the
> main patch (v32-0001). This version also includes 2 new tests:
>
> - refuse to run if the standby server is running
> - refuse to run if the standby was promoted e.g. it is not in recovery
>
> The first one exercises a recent change (standby should be stopped) and the
> second one covers an important requirement.
I have committed your version v33. I did another pass over the
identifier and literal quoting. I added quoting for replication slot
names, for example, even though they can only contain a restricted set
of characters, but it felt better to be defensive there.
Thanks.
I'm happy to entertain follow-up patches on some of the details like
option naming that were still being discussed. I just wanted to get the
main functionality in in good time. We can fine-tune the rest over the
next few weeks.
Agree. Let's continue the discussion about the details.
> Based on the discussion [1] about the check functions, Vignesh suggested
> that it
> should check both server before exiting. v33-0003 implements it. I don't
> have a
> strong preference; feel free to apply it.
I haven't done anything about this.
... including this one.