On 9/2/19 12:05 PM, Erik Rijkers wrote:
> On 2019-09-02 17:36, Jonathan S. Katz wrote:
>> On 9/2/19 11:19 AM, Jonathan S. Katz wrote:
>>> Please see attached for the latest draft. I tried to move this closer to
>
>
> 'common-table expression' should be
> 'common table expression'
> If you really do prefer the hyphen there then it should also be in the
> other usage of 'Common table expressions' in this text, I think.
You're correct, there should not be a hyphen there.
> 'most-common value' should be
> 'most common value'
There seems to be a few ways of doing this; I had gone by what was
documented in CREATE STATISTICS[1], so my preference is to leave it as is.
> 'that build on the implementation of the SQL standard' Perhaps better:
> 'that build on the SQL standard'
I modified it with a different take. I think the goal is to capture that
PostgreSQL continues to implement newer elements of the SQL standard.
"Building on" could sound like that we are adding enhancements on top of
the standard (which there are certainly cases where we do :) and I think
the end goal is to capture that we are keeping up with the evolution of SQL.
> 'JSON path expressions' Perhaps better:
> 'JSON path expressions'
The docs indicate there is a space[2] unless referring to the specific
data type, so I would recommend leaving it as is.
> And perhaps 'aka' should be fully written out 'also known as'. For us
> non-native speakers it takes a while before all these abbreviations
> become clear. I know it's taken me a few years before I decoded it :)
I did a s/aka/also known as/
Thanks!
Jonathan
[1] https://www.postgresql.org/docs/12/sql-createstatistics.html
[2]
https://www.postgresql.org/docs/12/functions-json.html#FUNCTIONS-SQLJSON-PATH