Re: Fix vcregress plpython3 warning

On 1/7/22 07:20, Juan José Santamaría Flecha wrote:
> Hi,
>
> When running the plcheck in Windows we get the following warning, it
> is visible in the cfbots [1]:
>
> Use of uninitialized value $1 in concatenation (.) or string at
> src/tools/msvc/vcregress.pl <http://vcregress.pl> line 350.
>
> This points to mangle_plpython3 subroutine. The attached patch
> addresses the problem.
>
> [1] http://commitfest.cputube.org/


Yeah, this code is not a model of clarity though. I had to think through
it and I write quite a bit of perl. I would probably write it something
like this:


s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ;


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com