Hi,
On Fri, Oct 31, 2025 at 08:41:46AM +0100, Peter Eisentraut wrote:
> On 31.10.25 05:31, Bertrand Drouvot wrote:
> > For PG19, we could:
> >
> > Add a comment in the code documenting that XLogRecPtrIsInvalid() is deprecated
> > and that we will enforce a "deprecated" attribute on it in PG24.
>
> Just a code comment for now seems reasonable. I wouldn't make any
> predictions about the future in code comments, though.
Done that way in 0001 attached.
Also in passing I realized that v2 did miss doing a replacement:
"PageGetLSN(page) == InvalidXLogRecPtr" in vacuumlazy.c.
I changed it "manually" for now in 0002 and checked that no other replacements
is missing.
Will fix the associated coccinelle script.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com