Re: Report bytes and transactions actually sent downtream
От | Bertrand Drouvot |
---|---|
Тема | Re: Report bytes and transactions actually sent downtream |
Дата | |
Msg-id | aNJBzxebbWLabunq@ip-10-97-1-34.eu-west-3.compute.internal обсуждение исходный текст |
Ответ на | Re: Report bytes and transactions actually sent downtream (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>) |
Ответы |
Re: Report bytes and transactions actually sent downtream
|
Список | pgsql-hackers |
Hi, On Fri, Sep 19, 2025 at 08:11:23PM +0530, Ashutosh Bapat wrote: > On Fri, Sep 19, 2025 at 11:48 AM shveta malik <shveta.malik@gmail.com> wrote: > > > 0001 is the previous patch > 0002 changes addressing your and Bertrand's comments. Thanks for the new patch version! I did not look closely to the code yet but did some testing and I've one remark regarding plugin_filtered_bytes: It looks ok when a publication is doing rows filtering but when I: - create a table and use pg_logical_slot_get_changes with ('skip-empty-xacts', '0') then I see plugin_sent_bytes increasing (which makes sense). - create a table and use pg_logical_slot_get_changes with ('skip-empty-xacts', '1') then I don't see plugin_sent_bytes increasing (which makes sense) but I also don't see plugin_filtered_bytes increasing. I think that would make sense to also increase plugin_filtered_bytes in this case (and for the other options that would skip sending data). Thoughts? Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: