On Mon, Sep 15, 2025 at 05:33:45PM -0500, Sami Imseih wrote:
> I think it's better to use ->pending here, since this is referenced
> as an example and most real-world cases will likely want to use
> ->pending for performance reasons.
Yes, it should use the pending entry. b757abefc041 did not get that
completely right.
The purpose of this code is also to serve as a template, so better
that it does the correct thing.
How about renaming "statent" to "pending" in pgstat_report_inj(), as
well? That would be a bit more consistent with the subscription stat
case, at least.
--
Michael