Re: Tab completion for GRANT MAINTAIN

On 18.04.23 11:08, Ken Kato wrote:
> Hi hackers,
>
> I found that GRANT MAINTAIN is not tab-completed with ON, so here is a 
> patch.

Hi,

the patch applies cleanly and now GRANT MAINTAIN tab-completes with ON. 
For the sake of completeness I tested a whole statement:

postgres=# GRANT M<tab>

=> postgres=# GRANT MAINTAIN

postgres=# GRANT MAINTAIN <tab>

=> postgres=# GRANT MAINTAIN ON

postgres=# GRANT MAINTAIN ON t <tab>

=> postgres=# GRANT MAINTAIN ON t TO

postgres=# GRANT MAINTAIN ON t TO <tab><tab>

=>

CURRENT_ROLE pg_monitor                   pg_use_reserved_connections
CURRENT_USER                 pg_read_all_data pg_write_all_data
pg_checkpoint                pg_read_all_settings pg_write_server_files
pg_create_subscription       pg_read_all_stats postgres
pg_database_owner            pg_read_server_files         PUBLIC
pg_execute_server_program    pg_signal_backend SESSION_USER
pg_maintain                  pg_stat_scan_tables

I've marked the CF entry as "ready for committer"

Best, Jim