Hi,
On 3/20/23 8:32 AM, Michael Paquier wrote:
>
> /* Total time previously charged to function, as of function start */
> - instr_time save_f_total_time;
> + instr_time save_total_time;
> I have something to say about this one, though.. I find this change a
> bit confusing. It may be better kept as it is, or I think that we'd
> better rename also "save_total" and "start" to reflect in a better way
> what they do, because removing "f_" reduces the meaning of the field
> with the two others in the same structure.
Thanks for looking at it!
Good point and keeping it as it is currently would not
affect the work that is/will be done in [1].
So, please find attached V2 attached taking this comment into account.
[1]: https://www.postgresql.org/message-id/flat/89606d96-cd94-af74-18f3-c7ab2b684ba2%40gmail.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com