Re: pgsql: Read include/exclude commands for dump/restore from file

Hi Daniel,

On Wed, Nov 29, 2023 at 02:21:28PM +0000, Daniel Gustafsson wrote:
> Read include/exclude commands for dump/restore from file
>
> When there is a need to filter multiple tables with include and/or exclude
> options it's quite possible to run into the limitations of the commandline.
> This adds a --filter=FILENAME feature to pg_dump, pg_dumpall and pg_restore
> which is used to supply a file containing object exclude/include commands
> which work just like their commandline counterparts. The format of the file
> is one command per row like:
>
>     <command> <object> <objectpattern>
>
> <command> can be "include" or "exclude", <object> can be table_data, index
> table_data_and_children, database, extension, foreign_data, function, table
> schema, table_and_children or trigger.
>
> This patch has gone through many revisions and design changes over a long
> period of time, the list of reviewers reflect reviewers of some version of
> the patch, not necessarily the final version.

mamba is unhappy with the new filter.c:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2023-11-30%2002%3A53%3A25

For instance:
filter.c: In function 'filter_get_keyword':
filter.c:188:17: error: array subscript has type 'char' [-Werror=char-subscripts]
188 |  while (isspace(*ptr))
    |                 ^
--
Michael