Re: missing requirement on ccache in postgresql16-devel

On Thu, Oct 26, 2023 at 10:42:10PM +0100, Devrim Gunduz wrote:
> 
> Hi,
> 
> On Wed, 2023-10-25 at 13:21 -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > On Wed, Oct 25, 2023 at 11:25:15AM -0400, Greg Hennessy wrote:
> > > > The file /usr/pgsql-16/lib/pgxs/src/Makefile.global has a
> > > > reference
> > > > to ccache but the rpm doesn't list this as a dependency. I would
> > > > like
> > > > to submit that it is a bug that it does not.
> > 
> > > Uh, ccache is an _optional_ way to speed up compilation.  It is not
> > > a requirement/dependency.
> > 
> > Yeah, but if the Makefile says "CC = ccache gcc" then anybody
> > trying to build under PGXS will fail if they don't have ccache
> > installed. 
> 
> Makefile.global has this reference to ccache on RHEL 9 and Fedora:
> 
> CLANG = /usr/lib64/ccache/clang
> 
> which is caused by:
> 
> %if 0%{?rhel} && 0%{?rhel} == 8
>         export CLANG=%{_bindir}/clang LLVM_CONFIG=%{_bindir}/llvm-config-64
> %endif
> 
> (so this issue does not exist on RHEL 8).
> 
> Pushed a fix to PostgreSQL 17. I'll check the results tomorrow, and then
> will patch PostgreSQL 11+.
> 
> Greg: Thanks for the report. The changes will appear in next month's
> minor release set (Nov 9). I'm not inclined to push an update set just
> for this issue.

Great, thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.