On Fri, Sep 29, 2023 at 11:26:55AM +0200, Peter Eisentraut wrote:
> Your patch still leaves various mentions of Mkvcbuild.pm and Project.pm in
> other files, including in
Indeed, thanks. I didn't think to check for references to these
modules.
> config/perl.m4
Here is the thing:
# switches for symbols not beginning with underscore. Some exceptions are the
# Windows-specific -D_USE_32BIT_TIME_T and -D__MINGW_USE_VC2005_COMPAT; see
# Mkvcbuild.pm for details.
And we'd lose quite some information here. meson.build loops back to
perl.m4 for this part. Reformating the comments perl.m4 should do the
job.
> meson.build
These were in Project::_new() and WriteItemDefinitionGroup(). Just
removing the reference does not remove any information.
> src/bin/pg_basebackup/Makefile
-# If you add or remove files here, also update Mkvcbuild.pm, which only knows
-# about OBJS, not BBOBJS, and thus has to be manually updated to stay in sync
-# with this list.
This can be removed, I guess.
> src/bin/pgevent/meson.build
The reference can be removed. The original says nothing about the use
of DisableLinkerWarnings() in this case.
> src/common/Makefile
> src/common/meson.build
These two have the same copy-pasted comment, and the reference can be
removed.
> src/interfaces/libpq/Makefile
Can be removed once the MSVC files are gone.
> src/port/Makefile
Can be removed.
Attached is a v2 with these adjustments, for now.
--
Michael