On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> Thanks for picking this up.
>
> On Thu, Sep 07, 2023 at 03:33:57PM -0400, Bruce Momjian wrote:
> > The default value is <systemitem class="systemname">localhost</systemitem>,
> > which allows only local TCP/IP <quote>loopback</quote> connections to be
> > - made. While client authentication (<xref
> > + made. If <varname>listen_addresses</varname> is not empty,
> > + the server will start if it can open a <varname>port</varname>
> > + on at least one TCP/IP address. A warning will be emitted for
> > + any TCP/IP address which cannot be opened.
>
> I think we should move this sentence to before the ѕentence about the
> default value. That way, "If the list is empty, ..." is immediately
> followed by "If the list is not empty, ..."
>
> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> something along the lines of
>
> If listen_addresses is not empty, the server will start only if it can
> listen on at least one of the specified addresses. A warning will be
> emitted for any addresses that the server cannot listen on.
Good idea, updated patch attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.