On Fri, Aug 18, 2023 at 02:30:31PM +1200, Thomas Munro wrote:
> Give me a couple of days and I'll look into how back-patchable the
> tests can be made, and see what else we can test. Perhaps it's not
> strictly necessary to back-patch the fix further than 15, but I think
> we should definitely consider it, and I don't like the idea of not
> having the tests accompanying the change.
Okay, cool.
> If you have any ideas about how to write a more efficient version of
> advance_to_record_splitting_zone() (or I guess that should really be
> advance_to_record_header_splitting_zone()), and generally how to make
> the perl better,
Yeah, I think that there are ways to reduce the number of records
generated.
> and how to get those constants we need from the
> source or binaries, then I'm all ears.
A new perl routine able to do a pg_control --includedir that scans a
defined header with a regexp would be able to make the job for the
constants. If you're interested, I can code that up.
--
Michael