Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Дата
Msg-id YRxQ1sN5ceWPgwdM@paquier.xyz
обсуждение исходный текст
Ответ на Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения 
On Tue, Aug 17, 2021 at 09:39:30AM -0400, Tom Lane wrote:
> OK, but the commit message should explain why they're getting reverted.

Sure.  aef8948 gets down because of the performance impact.  ccf4e27
was a cleanup following up aef8948, that loses its meaning.  And
c3826f8 cannot be let alone because of the reasons why aef8948 was
introduced, as it has no safety net for out-of-bound handling in the
result buffer allocated.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: The Free Space Map: Problems and Opportunities