Re: Fix comment in SnapBuildFindSnapshot

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Fix comment in SnapBuildFindSnapshot
Дата
Msg-id Y4RnZAD9h+0hw1WM@paquier.xyz
обсуждение исходный текст
Ответ на Fix comment in SnapBuildFindSnapshot  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: Fix comment in SnapBuildFindSnapshot  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Mon, Nov 28, 2022 at 11:13:23AM +0900, Masahiko Sawada wrote:
> We have the following comment in SnapBuildFindSnapshot():
>
>     * c) transition from FULL_SNAPSHOT to CONSISTENT.
>     *
>     * In FULL_SNAPSHOT state (see d) ), and this xl_running_xacts'
>
> It mentions "(state d) )", which seems like a typo of "(state d)", but
> there is no "state d" in the first place. Reading the discussion of
> the commit 955a684e040 that introduced this comment, this was a
> comment for an old version patch[1]. So I think we can remove this
> part.

Hm, yes, that seems right.  There are three "c) states" in these
paragraphs, they are incremental steps.  Will apply if there are no
objections.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Remove a unused argument from qual_is_pushdown_safe
Следующее
От: Ian Lawrence Barwick
Дата:
Сообщение: Re: Understanding, testing and improving our Windows filesystem code