RE: [HACKERS] Win32 pЭort of libpq

On 30-Sep-99 Vince Vielhaber wrote:
> On Thu, 30 Sep 1999, Dmitry Samersoff wrote:
>
>>
>> On 30-Sep-99 Edmund Mergl wrote:
>> > Hi,
>> >
>> > in the last few days I compiled libpq on Windows NT
>> > using MS Visual Studio 6.0. I followed the instructions
>> > given by Bob Kline <bkline@rksystems.com> in his mail from
>> > Fri, 3 Sep 1999.
>> > Unfortuanetely he sent his mail only to dbi-users, so I would
>> > like to repeat one major problem on this list.
>> >
>> > Here is an excerpt from his mail:
>> >
>> > 4. The DllMain function in src/interfaces/libpq/libpqdll.c of the
>> > PostgreSQL 6.5 sources, in which WSAStartup is invoked, is never called,
>> > which causes gethostbyname calls to fail.  Solution (more properly,
>> > "kludge" -- I know there's a cleaner fix somewhere, but this works for
>> > now): immediately after the local declarations for the connectDB function
>> > in src/interfaces/libpq/fe-connect.c:
>> >
>> >#ifdef WIN32
>> >     static int WeHaveCalledWSAStartup;
>> >
>> >     if (!WeHaveCalledWSAStartup) {
>> >         WSADATA wsaData;
>> >         if (WSAStartup(MAKEWORD(1, 1), &wsaData)) {
>> >             sprintf(conn->errorMessage,
>> >                     "WSAStartup failed: errno=%d\n", h_errno);
>> >             goto connect_errReturn;
>> >         }
>> >         WeHaveCalledWSAStartup = 1;
>> >     }
>> >#endif
>>
>> You need not to take care wether WSAStartup is alredy called or not.
>> Windows handle it automatically.
>
> By calling it yourself you have more control over which minimum version
> will be loaded.

Yes, but you can just call

   WSADATA wsaData;
   if (WSAStartup(MAKEWORD(1, 1), &wsaData)) {
            sprintf(conn->errorMessage,
                     "WSAStartup failed: errno=%d\n", h_errno);
            goto connect_errReturn;
   }


without WeHaveCalledWSAStartup at all.

---
Dmitry Samersoff, dms@wplus.net, ICQ:3161705
http://devnull.wplus.net
* There will come soft rains ...