RE: Modify the document of Logical Replication configuration settings

Hi,

On Thursday, January 19, 2023 3:14 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Jan 18, 2023 at 02:04:16PM +0530, Bharath Rupireddy wrote:
> > [1]
> > diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index
> > 89d53f2a64..6f9509267c 100644
> > --- a/doc/src/sgml/config.sgml
> > +++ b/doc/src/sgml/config.sgml
> > @@ -4326,7 +4326,8 @@ restore_command = 'copy
> > "C:\\server\\archivedir\\%f" "%p"'  # Windows
> >         <para>
> >          Terminate replication connections that are inactive for longer
> >          than this amount of time. This is useful for
> > -        the sending server to detect a standby crash or network outage.
> > +        the sending server to detect a standby crash or logical replication
> > +        subscriber crash or network outage.
> >          If this value is specified without units, it is taken as milliseconds.
> >          The default value is 60 seconds.
> >          A value of zero disables the timeout mechanism.
>
> Perhaps we could do that, I am not sure whether this brings much in this
> section, though.
This might increase comprehensiveness of the doc slightly.

If we want to do this, it might be better to
add this kind of additions to other parameters such as
wal_receiver_timeout, wal_retrieve_retry_interval
and wal_receiver_status_interval, too.

BTH, thank you for having taken care of my patch, Michael-san!


Best Regards,
    Takamichi Osumi