On Tuesday, March 16, 2021 5:20 AM, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>The cases that complete with a query
>result are not case insensitive right now. This affects things like
>
>UPDATE T<tab>
>
>as well. I think your first patch was basically right. But we need to
>understand that this affects all completions with query results, not
>just the one you wanted to fix. So you should analyze all the callers
>and explain why the proposed change is appropriate.
Thanks for your review and suggestion. Please find attached patch V3 which was based on the first patch[1].
Difference from the first patch is:
Add tab completion support for all query results in psql.
complete_from_query
+complete_from_versioned_query
+complete_from_schema_query
+complete_from_versioned_schema_query
[1] https://www.postgresql.org/message-id/a63cbd45e3884cf9b3961c2a6a95dcb7%40G08CNEXMBPEKD05.g08.fujitsu.local
The modification to support case insensitive matching in " _complete_from_query" is based on "complete_from_const and
"complete_from_list".
Please let me know if you find anything insufficient.
Regards,
Tang