RE: POC: postgres_fdw insert batching
От | tsunakawa.takay@fujitsu.com |
---|---|
Тема | RE: POC: postgres_fdw insert batching |
Дата | |
Msg-id | TYAPR01MB299026DB0E91E513664C162FFEA30@TYAPR01MB2990.jpnprd01.prod.outlook.com обсуждение исходный текст |
Ответ на | Re: POC: postgres_fdw insert batching (Tomas Vondra <tomas.vondra@enterprisedb.com>) |
Ответы |
Re: POC: postgres_fdw insert batching
|
Список | pgsql-hackers |
From: Tomas Vondra <tomas.vondra@enterprisedb.com> > I took a look at this - there's a bit of bitrot due to 708d165ddb92c, so attached is > a rebased patch (0001) fixing that. > > 0002 adds a couple comments and minor tweaks > > 0003 addresses a couple shortcomings related to explain - we haven't been > showing the batch size for EXPLAIN (VERBOSE), because there'd be no > FdwState, so this tries to fix that. Furthermore, there were no tests for EXPLAIN > output with batch size, so I added a couple. Thank you, good additions. They all look good. Only one point: I think the code for retrieving batch_size in create_foreign_modify() can be replaced with a call to thenew function in 0003. God bless us. Regards Takayuki Tsunakawa
В списке pgsql-hackers по дате отправления: