RE: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented
От | |
---|---|
Тема | RE: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented |
Дата | |
Msg-id | TYAPR01MB2896C8DF324DA02EF1857491C4AE9@TYAPR01MB2896.jpnprd01.prod.outlook.com обсуждение исходный текст |
Ответ на | Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented (Fujii Masao <masao.fujii@oss.nttdata.com>) |
Ответы |
Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented
|
Список | pgsql-hackers |
>-----Original Message----- >From: Fujii Masao <masao.fujii@oss.nttdata.com> >Sent: Monday, October 4, 2021 1:59 PM >To: bt21tanigaway <bt21tanigaway@oss.nttdata.com>; RDH 加藤 慎也/Kato, >Shinya (NTT DATA) <Shinya11.Kato@jp.nttdata.com> >Cc: pgsql-hackers@lists.postgresql.org >Subject: Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet >implemented > > > >On 2021/10/04 11:17, bt21tanigaway wrote: >>>> else if (Matches("LOCK", MatchAny, "IN", "ACCESS|ROW") || >>>> - Matches("LOCK", "TABLE", MatchAny, "IN", >>>> "ACCESS|ROW")) >>>> + Matches("LOCK", "TABLE", MatchAny, "IN", >"ACCESS|ROW") >>>> +|| >>>> + Matches("LOCK", "ONLY", MatchAny, "IN", >"ACCESS|ROW") >>>> +|| >>>> + Matches("LOCK", "TABLE", "ONLY", MatchAny, "IN", >>>> +"ACCESS|ROW")) >>> I think this code is redundant, so I change following. >>> --- >>> else if (HeadMatches("LOCK") && TailMatches("IN", "ACCESS|ROW")) >>> --- >>> I created the patch, and attached it. Do you think? >> Thank you for update! >> I think that your code is more concise than mine. >> There seems to be no problem. > >The patch looks good to me, too. I applied cosmetic changes to it. >Attached is the updated version of the patch. Barring any objection, I will commit >it. Thank you for the patch! It looks good to me. Regards, Shinya Kato
В списке pgsql-hackers по дате отправления: