Dear hackers,
I found another failure related with the commit [1]. This is caused by missing
wait on the test code. Amit helped me for this analysis and fix.
# Analysis of the failure
The failure is that restored slot is two_phase = false, whereas the slot is
created as two_phase = true. This is because pg_upgrade was executed before all
tables are in ready state.
# How to fix
I think the test is not good. According to other subscription tests related with
2PC, they additionally wait until subtwophasestate becomes 'e'. It should be
added as well. PSA the patch.
[1]: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2023-12-01%2016%3A59%3A30
Best Regards,
Hayato Kuroda
FUJITSU LIMITED