RE: auto_explain: Include JIT output if applicable

Hi, 

> I think it's better to stay closer to what explain.c itself is doing - it's not like that if statement costs us
anythingreally...
 

Oh, I understood.
Thank you.

-----Original Message-----
From: Andres Freund [mailto:andres@anarazel.de] 
Sent: Saturday, September 29, 2018 2:11 PM
To: Shinoda, Noriyoshi (PN Japan GCS Delivery) <noriyoshi.shinoda@hpe.com>
Cc: Lukas Fittl <lukas@fittl.com>; Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: auto_explain: Include JIT output if applicable

Hi,

On 2018-09-29 05:04:25 +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> I tried this feature.
> I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’.
> 
> Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago.
> So I attached a patch to delete this if statement.

I think it's better to stay closer to what explain.c itself is doing - it's not like that if statement costs us
anythingreally...
 

- Andres