Re: XADataSource implementation

(Reposting to pgsql-jdbc@postgresql.org, since it haven't shown up yet).

On Mon, 12 Sep 2005, Oliver Jowett wrote:

> Heikki Linnakangas wrote:
>> I've been working on the XADataSource implementation. Patch attached.
>> Test case is in the separate zip file, because I couldn't get cvs to
>> include it in the diff.
>
> This looks good to me. A few comments:
>
> - we'll need to wrap translatable strings in GT.tr() calls
> - there are some places where you compare Xids by identity (==) --
> shouldn't these be using .equals()?
> - do we really need all of that Base64 encoder/decoder class? Seems like
> we could get away with something much more simple.

Ok, I finally got around fixing these.

Updated patch can be found at:

http://users.tkk.fi/hlinnaka/pgsql/twophase_jdbc_20050921.diff

I now also tested it with JBoss. It seems that JBoss does utilise transaction
interleaving by default, which we don't support. However, it can easily be
turned off by setting the "track-connection-by-tx"-parameter in the datasource
configuration. The configuration examples also set it for Oracle, MSSQL and
Facets (what is it, BTW?), so it seems acceptable to me.

- Heikki