Re: Problems using pgxs on Win32

Dear Thomas,

>>>   ifdef PGXS
>>>   override CPPFLAGS := -I$(includedir_server)
>>> -I$(includedir_server)/port/win32 -I$(includedir_internal) $(CPPFLAGS)
>>>   else # not PGXS
>> 
>> Why can't you #include "port/win32/some_file.h" which would (I think)
>> avoid the issue without adding a win32 specific -I to all architectures??
>> I'm not sure I'm happy if I see a win32 path when compiling under some
>> unix.
>> 
> I'm not sure I understand. I'm not the one including the missing files. They 
> are included when I include postgres.h.

Ok.

It seems that this directory provides fake header files to replace "unix" 
system headers. Hence ISTM that no one wants this -I on any other 
platform, so the possible inclusion must be added under some condition, 
not just ifdef PGXS.

I'm wondering how it works within the source tree. I guess the 
Makefile.port must/should take care of this issue, and maybe it is broken 
under pgxs? I'll look into that, but I cannot test anything:-(

-- 
Fabien Coelho - coelho@cri.ensmp.fr