Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance

On Sat, 22 Oct 2005, Andrew Dunstan wrote:

>
> Well, first, have you tested it with "make check"? I am not sure if
> there's any great value in supporting a non null old value param.
>

Yeah, I've managed to install in my slow windows box and tested it.
Supporting ovalue is just the by-product. If it works, I will complete the
patch by adding threading safe critical section protect.

> Second, please note that the PostgreSQL community convention is for
> patches as context diffs, not unidiffs.
>
Ok.

> I guess there are several ways to skin this cat - the way I had sort of
> worked out reading the MSDN docs was to call QueueUserAPC on the timer
> thread. I'd like to know what Magnus and Merlin especially think out it.
>
I am not sure - does this not require another thread in an alterable
state?

Regards,
Qingqing