Re: TODO item -- Improve psql's handling of multi-line

On Sun, 4 Dec 2005, Bruce Momjian wrote:

>
> Can I have this patch in diff -c?  The format you used isn't reliable
> for patching.  Thanks.

Sorry, I didn't know that the patch should be done with "-c".
Ok, now I'm sending it diff -c

Regards,
        Sergey

>
> ---------------------------------------------------------------------------
>
> Sergey E. Koposov wrote:
> > Hello,
> >
> > Sorry for not quick problem fixing, I was quite busy last time...
> >
> > I submit the new version of my patch (against the CVS tip), correcting the
> > problem with \edit (pointed by Andreas). So now everything works fine.
> >
> > With Best Regards,
> >
> >         Sergey
> >
> >
> >
> > On Thu, 1 Dec 2005, Bruce Momjian wrote:
> >
> > >
> > > Where are we on this patch?  Was it submitted?  Applied?  Just an idea?
> > >
> > > ---------------------------------------------------------------------------
> > >
> > > Andreas Seltenreich wrote:
> > > > Sergey E. Koposov writes:
> > > >
> > > > > I'm proposing the small patch for the TODO item -- Improve psql's handling
> > > > > of multi-line queries. With this patch the multi-line queries are saved
> > > > > by readline as whole and not line by line.
> > > >
> > > > I like it already!
> > > >
> > > > > This is my first patch for Postgres but it seems to work and to not break
> > > > > anything.
> > > > >
> > > > > I'm waiting for review, comments, objections, etc...
> > > >
> > > > Did you consider its interaction with \e? Editing the query_buffer
> > > > with \e will leave that query prefixed with \e in the history. That
> > > > wasn't the case before your patch.
> > > >
> > > > Also, using \e several times on a query without sending it (i.e.
> > > > without a semicolon) will yield a history entry of a concatenation of
> > > > old query buffers.
> > > >
> > > > Thanks,
> > > > Andreas
> > > >
> > > > ---------------------------(end of broadcast)---------------------------
> > > > TIP 4: Have you searched our list archives?
> > > >
> > > >                http://archives.postgresql.org
> > > >
> > >
> > >
> >
> >
> > *****************************************************
> > Sergey E. Koposov
> > Max-Planck Institut for Astronomy
> > Web: http://lnfm1.sai.msu.ru/~math
> > E-mail: math@sai.msu.ru
> >
>
> Content-Description:
>
> [ Attachment, skipping... ]
>
>

*****************************************************
Sergey E. Koposov
Max-Planck Institut for Astronomy
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math@sai.msu.ru