Re: More on "What am I doing wrong!"

On Sat, 18 May 2002, mordicus wrote:

> I found another problem with your plpgsql function in apply_parent_details,
>
> UPDATE "Parents" SET "MTitle" = ptitle, "MForename" = pforename, "MSurname" =
> psurname, "Addr1" = addr1, "Addr2" = addr2, "Addr3" = addr3, "Town" = town,
> "Postcode" = postcode, "TelNo1" = telno1, "TelNo2" =@telno2, "eMail" = email
>
> "TelNo2" =@telno2 ??? should be juste telno2, no ?

Yes you are correct, but this code is never called in this context.
However, all the statements have since been changes and now use $n.

> Another thing, if possible, don't use oid, use sequence instead, more
> reliable.

Ok, I'll change it.

> And when you declare your function, don't use "iscachable" option since this
> type of function is not cacheable, it can cause some probs.

It's not! Well I consider this a prime candidate for caching. Oh well.

> And, last thing, sorry for my bad english :)

:-)

>

--
Regards,


Wm. G. Urquhart
Custom Software Solutions
http://www.wurquhart.co.uk