Re: [HACKERS] pg_dump, and strings

On Oct 31, Ansley, Michael mentioned:

> Hi, all
> 
> In pg_dump there is a file called common.c.  This file has some string
> handling routines in it that return a pointer to a fixed-length, static
> string (char *).  I need to remove the fixed-length bit (besides the fact
> fact that this is horrendously un-threadsafe).  So, what is the best
> mechanism to use on replacement?  There seem to be two fairly standard
> methods to use, a) make the calling function allocate the memory it
> requires, and pass that in to the called function, or b) the called function
> allocates memory using a documented call (say, malloc), and hands
> responsibility for freeing the memory to the calling function.  Given the
> non-fixed-length constraint, the second option would appear better, but does
> any body out there have any other ideas?
> 
> MikeA

Of course malloc is not very thread-safe either.

But as far is I'm concerned, the difference between a) and b) is cosmetic.

-- 
Peter Eisentraut                  Sernanders vaeg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden