Re: patch for contrib/intarray (current CVS)

On Thu, 2 Aug 2001, Tom Lane wrote:

> Oleg Bartunov <oleg@sai.msu.su> writes:
> > please apply attached patch to current CVS.
> > 1. Fixed error with empty array ( '{}' ),
> >    test data changed to include such data
> > 2. Test a dimension of an array ( we support only one-dimension)
>
> Looks okay in a quick glance, except error message spelling is poor:
>
> ! #define ARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ?
(elog(ERROR,"Arrayis not one-dimentional: %d dimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )
 
>
> Should be "one-dimensional" and "dimensions".  Bruce, would you fix that
> when you apply it?

oops :-%

>
>             regards, tom lane
>
Regards,    Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83