Re: Auto-increment serial (Postgresql JDBC driver w/

On Wed, 23 Sep 2004, Jaroslaw J. Pyszny wrote:

> W li�cie z sro, 22-09-2004, godz. 21:59, Kris Jurka pisze:
> > On Wed, 22 Sep 2004, Jaroslaw J. Pyszny wrote:
> [...]
>
> second patch
>

I've applied the ResultSetMetaData.isAutoIncrement part of this patch, but
you changed what you were doing in DatabaseMetaData and I wanted to
discuss that first.  Now you are adding the serial pseudotypes to the
getTypeInfo results.

1) With the addition of the new types, should we only return true for
AUTO_INCREMENT on the serial types and not the integer types?

2) Is it necessary to return all four versions of the types (serial,
serial4, bigserial, and serial8)?  To me this seems to just add confusion
and perhaps we should just pick a pair of these to use.

3) If we are going to add these as valid types, it seems we should alter
DatabaseMetaData.getColumns to return "serial" for the TYPE_NAME column as
well.

Kris Jurka