Re: Suggested fix for pg_dump

On Sun, 7 Jan 2001, Philip Warner wrote:

>
> The problem with pg_dump and renamed primary key attrs can be fixed by
> using the indkey attribute of pg_index to lookup attrs in pg_class - this
> is what pg_dump does when it dumps indexes. If I am going to make this
> change, I would also like to split the PK definition out from the table
> definition, so we would have:
>
>     Create Table fred(f1 int);
>     Alter Table fred add constraint primary key(f1);
>
> instead of:
>
>     Create Table fred(f1 int, primary key(f1));
>
> The reason for this is that it will improve load performance, and begin to
> allow pg_restore to separate constraints from tables.
>
> Is this OK? Or inappropriate for beta?
>
> Needless to say, I don't really want to revisit this piece of code in 3
> months time, so I'd like to do it now.

From Tatsuo's example, it looks critical enough that it should be fixed
before release, and since its a 'support program' issue, not a 'core
server' issue, ramifications of fixing it aren't as big as if it was a
'core server' issue ... go for it