Dear Shubham,
> I had run valgrind with pg_createsubscriber to see if there were any
> issues.
Thanks for running the tool!
> Valgrind reported the following issues:
> ==651272== LEAK SUMMARY:
> ==651272== definitely lost: 1,319 bytes in 18 blocks
> ==651272== indirectly lost: 1,280 bytes in 2 blocks
> ==651272== possibly lost: 44 bytes in 3 blocks
> ==651272== still reachable: 3,066 bytes in 22 blocks
> ==651272== suppressed: 0 bytes in 0 blocks
> ==651272==
> ==651272== For lists of detected and suppressed errors, rerun with: -s
> ==651272== ERROR SUMMARY: 17 errors from 17 contexts (suppressed: 0 from
> 0)
> The attached report has the details of the same.
I read the report. I'm not sure all entries must be fixed. Based on other client
tools, old discussions [1], and current codes, I thought we could determine the below
rule:
* For global variables (and their attributes), no need to free the allocated memory.
* For local variables (and their attributes) in main(), no need to free the allocated memory.
* For local variables in other functions, they should be free'd at the end of the function.
Per above rule and your report, I made a top-up patch which adds pg_free() and
destroyPQExpBuffer() several places. How do you think?
[1]: https://www.postgresql.org/message-id/40595e73-c7e1-463a-b8be-49792e870007%40app.fastmail.com
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/