RE: Parallel INSERT SELECT take 2

Поиск
Список
Период
Сортировка
От houzj.fnst@fujitsu.com
Тема RE: Parallel INSERT SELECT take 2
Дата
Msg-id OS0PR01MB5716A5C5FDB8F0A44791B41194509@OS0PR01MB5716.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: Parallel INSERT SELECT take 2  (Greg Nancarrow <gregn4422@gmail.com>)
Ответы Re: Parallel INSERT SELECT take 2  (Greg Nancarrow <gregn4422@gmail.com>)
Список pgsql-hackers
> 
> Currently the 1st patch actually also contains the changes for the
> Parallel-SELECT-for-INSERT functionality. This is not obvious.
> So I think this should be split out into a separate patch (i.e. the minor planner
> update and related planner comment changes,
> is_parallel_allowed_for_modify() function, max_parallel_hazard() update, XID
> changes).
> Also, the regression tests' "serial_schedule" file has been removed since you
> posted the v3-POC patches, so you need to remove updates for that from your
> 3rd patch.

Thanks for the comments, I have posted new version patches with this change. 

> How about reorganisation of the patches like the following?
> 0001: CREATE ALTER TABLE PARALLEL DML
> 0002: parallel-SELECT-for-INSERT (planner changes,
> max_parallel_hazard() update, XID changes)
> 0003: pg_get_parallel_safety()
> 0004: regression test updates

Thanks, it looks good and I reorganized the latest patchset in this way.

Attaching new version patches with the following change.

0003
Change functions arg type to regclass.

0004
remove updates for "serial_schedule".

Best regards,
houzj

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Borisov
Дата:
Сообщение: Re: OOM in spgist insert
Следующее
От: "houzj.fnst@fujitsu.com"
Дата:
Сообщение: RE: Parallel INSERT SELECT take 2