RE: [HACKERS] freefuncs.c is never called from anywhere!?
От | Hiroshi Inoue |
---|---|
Тема | RE: [HACKERS] freefuncs.c is never called from anywhere!? |
Дата | |
Msg-id | NDBBIJLOILGIKBGDINDFIEIGCCAA.Inoue@tpf.co.jp обсуждение исходный текст |
Ответ на | freefuncs.c is never called from anywhere!? (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: [HACKERS] freefuncs.c is never called from anywhere!?
|
Список | pgsql-hackers |
> -----Original Message----- > From: owner-pgsql-hackers@postgreSQL.org > [mailto:owner-pgsql-hackers@postgreSQL.org]On Behalf Of Tom Lane > > I was rather bemused to discover just now that the node-freeing > functions in nodes/freefuncs.c are never called from anywhere; > in fact, the module hasn't got a single exported entry point! > > (I expect that freeObject() is supposed to be an external entry > point; perhaps it got demoted to a static during one of Bruce's > periodic get-rid-of-unreferenced-global-symbols passes.) > > So much for all that tedious labor to maintain the freeXXX functions > every time we update a node type ;-) > As far as I see,freeObject() has a fundamental problem. Probably it couldn't free multiple references safely. Regards. Hiroshi Inoue Inoue@tpf.co.jp
В списке pgsql-hackers по дате отправления: