Re: Another incorrect comment for pg_stat_statements
От | Japin Li |
---|---|
Тема | Re: Another incorrect comment for pg_stat_statements |
Дата | |
Msg-id | MEYP282MB1669FB3A6F7AD9B0D949CA7CB624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM обсуждение исходный текст |
Ответ на | Re: Another incorrect comment for pg_stat_statements (Richard Guo <guofenglinux@gmail.com>) |
Ответы |
Re: Another incorrect comment for pg_stat_statements
|
Список | pgsql-hackers |
On Wed, 28 Jun 2023 at 11:22, Richard Guo <guofenglinux@gmail.com> wrote: > On Wed, Jun 28, 2023 at 10:53 AM Japin Li <japinli@hotmail.com> wrote: > >> >> Hi, hackers >> >> There has $subject that introduced by commit 6b4d23feef6. When we reset >> the entries >> if all parameters are avaiable, non-top-level entries removed first, then >> top-level >> entries. > > > I did not see the diffs. Maybe uploaded the wrong attachment? > My bad! Here is the patch. Thanks! diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 21bede29fe..670c993816 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -2552,7 +2552,7 @@ entry_reset(Oid userid, Oid dbid, uint64 queryid) key.dbid = dbid; key.queryid = queryid; - /* Remove the key if it exists, starting with the top-level entry */ + /* Remove the key if it exists, starting with the non-top-level entry */ key.toplevel = false; entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL); if (entry) /* found */ -- Regrads, Japin Li.
В списке pgsql-hackers по дате отправления: