Re: [HACKERS] Time based lag tracking for logical replication

On May 11, 2017 8:08:11 AM PDT, Simon Riggs <simon@2ndquadrant.com> wrote:
>On 11 May 2017 at 14:12, Petr Jelinek <petr.jelinek@2ndquadrant.com>
>wrote:
>
>>> Attached patch is Petr's patch, slightly rebased with added pacing
>>> delay, similar to that used by HSFeedback.
>>>
>>
>> This looks reasonable. I would perhaps change:
>>> +       /*
>>> +        * Track lag no more than once per
>WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>>> +        */
>>
>> to something like this for extra clarity:
>>> +       /*
>>> +        * Track lag no more than once per
>WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>>> +        * to avoid flooding the lag tracker on busy servers.
>>> +        */
>
>New patch, v3.
>
>Applying in 90 minutes, barring objections.

Could you please wait till tomorrow?  I've bigger pending fixes for related code pending/being tested that I plan to
pushtoday.  I'd also like to take a look before... 

Thanks,

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.