Re: Online checksums patch - once again

> On 26 Jun 2020, at 14:12, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Jun 25, 2020 at 5:43 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>> Sorry being a bit thick, can you elaborate which case you're thinking about?
>> CREATE TABLE sets the attribute according to the value of data_checksums, and
>> before enabling checksums (and before changing data_checksums to inprogress)
>> the bgworker will update all relhaschecksums from true (if any) to false.  Once
>> the state is set to inprogress all new relations will set relhaschecksums to
>> true.
>
> Oh, I think I was the one who was confused. I guess relhaschecksums
> only really has meaning when we're in the process of enabling
> checksums? So if we're in that state, then the Boolean tells us
> whether a particular relation is done, and otherwise it doesn't
> matter?

That is correct (which is why the name is terrible since it doesn't convey
that at all).

cheers ./daniel