Re: cursor control

> -----Original Message-----
> From: Johann Zuschlag [mailto:zuschlag2@online.de]
> Sent: 07 October 2005 15:53
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: cursor control
>
> Hi Dave,
>
> I don't understand the following in qresult.c:
>
> 503:        /* Speed up access */
> 504:        int                     fetch_count = self->fetch_count;
>
> And then:
>
> 515:        if (fetch_count < fetch_count)
> 516:        {
> 517:                /* return a row from cache */
> 518:                mylog("next_tuple: fetch_count < fcount:
>           returning tuple %d, fcount = %d\n", fetch_count,
> num_backend_rows);
> 519:                self->tupleField = the_tuples +
> (fetch_count * self->num_fields);               /* next row */
> 520:                self->fetch_count++;
> 521:                return TRUE;
> 522:        }
> 523:        else if (self->num_backend_rows < self->cache_size)
>
> Maybe I'm misled. But  I assume (fetch_count < fetch_count)
> will never
> become true.

Probably not :-). I would guess that it should read:

if (fetch_count < num_backend_rows)

However Anoop and Sivakumar are fixing Use Declare/Fetch at the moment
which means they are probably hacking code around here so I don't want
to go tweaking things right now.

Regards, dave.