Re: pgxs and pginstaller

> -----Original Message-----
> From: Thomas Hallgren [mailto:thhal@mailblocks.com]
> Sent: 23 September 2005 11:17
> To: Dave Page
> Cc: pgsql-hackers@postgresql.org
> Subject: Re: pgxs and pginstaller
>
> It's two things basically. One I think that the installer
> team can fix,
> the other is IMHO an error in the Makefile.global.in and
> should be fixed
> there.
>
> The first thing is the lib/pgxs/src/Makefile.global that is
> installed.
> It contains two paths that needs to change. The
> abs_top_srcdir and the
> prefix. In my patched file I use these settings:
>
> abs_top_srcdir =
> /c/Progra~1/PostgreSQL/8.1-beta2/src/postgresql-8.1beta2
> prefix := /c/Progra~1/PostgreSQL/8.1-beta2

Hmm, those are still msys paths which the installer doesn't know about.
Will it work with:

abs_top_srcdir = "C:\\Program
Files\\PostgreSQL\\8.1-beta2\\src\\postgresql-8.1beta2"
prefix := "C:\\Program Files\\PostgreSQL\\8.1-beta2"

Those should be Windows and Msys friendly.

> That seems to work fine. The second problem is that when I made that
> change, I also had to change code that appends 'postgresql'
> to all paths
> unless the path contains the word 'pgsql' or 'postgres'. A comment
> statest that this is to avoid 'directory clutter'. A better
> check would
> perhaps be to hardcode rules that explicitly avoids some well known
> directories (/usr/include etc.). That would give the user a better
> freedom to choose prefix without having this side-effect.
>
> My temporary patch for this was to remove all lines staring
> with 'ifeq'
> or 'endif' between line 66 and 102.

I agree with your earlier comment - this should definitely be fixed in
PostgreSQL, not pgInstaller.

Regards, Dave.