Re: Continuing encoding fun....

> -----Original Message-----
> From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> Sent: 05 September 2005 18:35
> To: Dave Page; pgsql-odbc@postgresql.org
> Cc: Marko Ristola; Johann Zuschlag; Anoop Kumar
> Subject: Re: [ODBC] Continuing encoding fun....
>
> > Either way, we're certainly not going to release the
> non-libpq version
> > any more.
>
> Ok, I also think that it is accordant to reason.
>
> > BTW, your version misses the changes to installer/psqlodbcm.wxs...
>
> Uga... Sorry.
>
> Ah.. I look at a part strange one.
> Please check it.:-)


Re patch:

--- connection.c.orig    Tue Sep  6 01:47:23 2005
+++ connection.c    Tue Sep  6 02:13:53 2005
@@ -1545,7 +1545,7 @@
         if (self->unicode)
         {
             if (!self->client_encoding ||
-                !stricmp(self->client_encoding, "UNICODE"))
+                stricmp(self->client_encoding, "UNICODE"))
             {
                 QResultClass    *res;
                 if (PG_VERSION_LT(self, 7.1))

The opposite of this change was made in 1.92 of connection.c:
http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/connection
.c?rev=1.92&content-type=text/x-cvsweb-markup

It seems to me that the current case is correct - in the Unicode driver
we *must* run with client_encoding = 'UNICODE' or it won't work
properly. That said, I wonder if we shouldn't just remove the if()
altogether, and unconditionally set the client encoding for the Unicode
driver.

Don't forget, this won't affect the ANSI/Multibyte case because it's
inside a "#ifdef UNICODE_SUPPORT".

What do you think Anoop?

Regards, Dave