Re: Continuing encoding fun....

> -----Original Message-----
> From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> Sent: 05 September 2005 05:57
> To: Dave Page; pgsql-odbc@postgresql.org
> Cc: Marko Ristola; Johann Zuschlag; Anoop Kumar
> Subject: Re: [ODBC] Continuing encoding fun....
>
> Hi Dave.
>
> > With this patch, you can build either the old style ANSI/Multibyte
> > driver, or the Unicode driver. I've also removed the -libpq
> suffix that
> > was added for testing, as this patch gives the driver a new
> name anyway.
> > When installed on a Windows system, you then get:
> >
> > psqlodbca.dll "PostgreSQL ANSI"
> > psqlodbcw.dll "PostgreSQL Unicode"
>
> Is it meant as follows after all?
> with libpq version
> psqlodbca.dll "PostgreSQL ANSI"
> psqlodbcw.dll "PostgreSQL Unicode"
> without libpq version
> psqlodbca.dll "PostgreSQL ANSI"
> psqlodbcw.dll "PostgreSQL Unicode"

Yes - I am not concerned with the socket version of the driver - in
fact, I was going to talk to Anoop about removing the old code because
we've had at least a couple of cases of people patching the wrong part,
or mistakenly using the socket code.

Either way, we're certainly not going to release the non-libpq version
any more.

> > Unless anyone has a better solution, I think this is the best fix to
> > allow users with non-Unicode friendly apps to work as they
> used to with
> > the older driver.
>
> Some complaint. Although I have not fully tried yet.-(
> I think that CRLF of a base code and patch is what it is hard to use.

Yes, I was too tired to try to fix the patch to remove the CRLF changes
:-( Still, they need to be fixed anyway.

BTW, your version misses the changes to installer/psqlodbcm.wxs...

> > Please shout ASAP if you object!!
>
> one vote is invested.

:-)

Regards, Dave