Re: [HACKERS] For review: Server instrumentation patch

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 01 August 2005 15:05
> To: Dave Page
> Cc: Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] [HACKERS] For review: Server
> instrumentation patch
>
> Dave Page wrote:
>
> >>
> >>pg_dir_ls isn't necessary for reading the logfiles;
> >>pg_logdir_ls will do
> >>this.
> >
> >
> > Err, yes, sorry - that was a thinko.
>
> The list isn't complete. pgadmin uses these three functions
> for logfile
> tracking:
>
> - pg_logdir_ls to list logfiles
> - pg_file_length to check for changes of the current logfile
> - pg_file_read to retrieve a logfile

Yes you're right, I didn't check thoroughly (in my defence, the coffee
machine broke this morning). Anyhoo, pg_file_stat is used by
pg_file_length, so that would be required as well.

None of those allow any modification of the filesystem, so do not suffer
the potential security issues that Tom was concerned about, so hopefully
there is no problem with them going in?

Regards, Dave.