Re: For review: Server instrumentation patch

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: 23 July 2005 20:01
> To: Dave Page
> Cc: PostgreSQL-development
> Subject: Re: [HACKERS] For review: Server instrumentation patch
>
>
> This patch looks good.  The only question I have is why you
> didn't want
> the pgport rename/unlink calls?  We usually use them unless there is
> some reason not to.

<thinks...> Probably because this was written originally for 7.4 (as a
pgAdmin contrib module) and I'm guessing the pgport rename/unlink
weren't there at that time. I can't think of any reason not to use them
- do you want an updated patch or are you OK to tweak it when applying?

Regards, Dave.