Re: New acinclude.m4

Thanks, patch applied.

> -----Original Message-----
> From: Raphaël Enrici [mailto:blacknoz@club-internet.fr]
> Sent: 19 May 2005 20:46
> To: Florian G. Pflug
> Cc: Adam H. Pendleton; Dave Page; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] New acinclude.m4
>
> Florian G. Pflug wrote:
> > Raphaël Enrici wrote:
> >
> >>Florian G. Pflug wrote:
> >>
> >>>Raphaël Enrici wrote:
> >>>
> >>>>I have warning concerning ENABLE_STATIC in configure
> script. Shouldn't
> >>>>we also remove it crom configure.ac ? (patch attached).
> >>>
> >>>
> >>>Does this mean the linking statically is not possible anymore?
> >>>Or has the check just moved to another place?
> >>
> >>To me, as Adam is making the build relying on wx-config
> flags, the build
> >> is considered static if wxWid was built with
> --disabled-shared passed
> >>to  its configure. In the case where wxWidgets has been built with
> >>--enable-shared, pgadmin will inherit this default and
> build dynamically
> >>(same thing if both shared and static wxWid libs were
> built, the shared
> >>build will become the default...).
> >
> > Will a statically-built wx make the _whole_ pgadmin link
> statically too,
> > or will only the wx-libraries be linkes statically and e.g. libpq
> > dynamically.
>
> To me, second case. wx static the rest of the world dynamic.
>
> >It would be the right thing to do, I guess - but then there
> > would be need for a global "--enable-static" flag, that defined
> > the linking-type for all other libs beside wx. At least for OSX,
> > linking the release-versions statically it the most reliable method,
> > while keeping the resulting app small.
>
> So, if I'm right we have lost this functionnality. But,
> again, I may be
> wrong.
>
> Can you  try the patch attached on OSX with a fresh checkout (don't
> apply the configure.ac I just sent) ? (I need to rebuild wxWid to
> generate static libs... it may take a moment).
>
> Cheers,
> Raphaël
>
> >>Maybe it would be worth to still being able to force a
> static build by
> >>passing "--static" to wx-config in our acinclude.m4.
> Something like :
> >>if we pas --enable-static to our configure, then pass --static to
> >>wx-config so that we build statically, if not then don't
> pass anything
> >>in particular.
> >
> > Sounds reasonable - additionally --enable-static should
> link e.g. libpq
> > statically too.
> >
> > greetings, Florian Pflug
> >
> >
> > ---------------------------(end of
> broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> >     (send "unregister YourEmailAddressHere" to
> majordomo@postgresql.org)
> >
>