Re: Query favourite comment

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Andreas Pflug
> Sent: 13 February 2006 13:52
> To: Magnus Hagander
> Cc: pgadmin-hackers
> Subject: [pgadmin-hackers] Query favourite comment
>
> After quite a while, I finally found the time to package a win32
> snapshot. Some comments:
>
> 1) apparently, we need two iconv dlls now: iconv.dll for xml2 and
> libiconv-2.dll for libpq. Hm...

I suspect we can get down to one by compiling libxml2 ourselves, however
that would probably make building pgAdmin far more difficult. Lesser of
two evils 'n' all that...

> 2) When adding a favourite, the whole buffer is taken, not just the
> marked area. This differs from the usual pgadmin behaviour
> (except "save
> as").

Yes, that seems a sensible change to make.

> 3) I would have expected more than just a "multiple
> clipboard" function.
> Why isn't the query executed immediately? Why does it replace
> the buffer
> completely? Why not just executing it, or insert at current selection?

I don't think executing immediately is ever likely to be the best idea.
As for the replace vs. insert issue, when I tested it it asked me if I
wanted to replace the query and gave me yes/no/cancel options, with No
doing an insert.

Regards, Dave.