Re: Patch: Config editors

Thanks, patch applied. I made some additional changes to the editors to
prevent undo on the wrong line, and to prevent deletion of the blank
'new' item.

Regards, Dave.

> -----Original Message-----
> From: Magnus Hagander [mailto:mha@sollentuna.net]
> Sent: 23 January 2006 15:41
> To: Dave Page; pgadmin-hackers@postgresql.org
> Subject: RE: [pgadmin-hackers] Patch: Config editors
>
> Updated version attached:
>
> * Include xrc file that was missing last time ;-) Haven't included the
> appropriate .cpp update because it was huge ;-)
> * Fix help button in all editors (didn't work in hba editor either..)
> * Add delete button
> * Disable the hint button in the hba and pgpass editors, because we
> don't hint anyway
> * "Fix" the undo by disabling the undo button when you delete
> something,
> so you don't think it works (see below)
>
>
> Now, as for the undo functionality. The undo as it is now in these
> dialogs don't work like a standard undo which is "undo the
> latest edit".
> It is "undo the latest edit on the current line". So this
> patch actually
> follows that (since there is no way to select a deleted
> line). Changing
> this to a "normal undo" is a different patch alltogether ;-)
>
> For example:
> 1) Edit line #1
> 2) Edit line #2
> 3) Select line #1
> 4) Click undo
> 5) Watch how the change from (1) gets reverted, not the one from (2)
>
>
> //Magnus
>
>
> > -----Original Message-----
> > From: Dave Page [mailto:dpage@vale-housing.co.uk]
> > Sent: Monday, January 23, 2006 4:00 PM
> > To: Magnus Hagander; pgadmin-hackers@postgresql.org
> > Subject: RE: [pgadmin-hackers] Patch: Config editors
> >
> > Patch discussed with Magnus on IM. To be reposted with fixes for the
> > following:
> >
> > - Undo button doesn't undo a delete.
> > - There is no delete button on the dialogue
> > - Help button on the main editor window doesn't work.
> >
> > Regards, Dave.
> >
> > > -----Original Message-----
> > > From: pgadmin-hackers-owner@postgresql.org
> > > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Magnus
> > > Hagander
> > > Sent: 23 January 2006 13:18
> > > To: pgadmin-hackers@postgresql.org
> > > Subject: [pgadmin-hackers] Patch: Config editors
> > >
> > > Attached patch implements an editor for pgpass.conf/.pgpass
> > modeled on
> > > the HBA editor. In doing so it also:
> > >
> > > * Adds the ability to delete a row to the pg_hba editor
> > > * Moves the "get the name of the password file" to
> pgSettings so it
> > > can be shared. Sets up a tiny bit of infrastructure for
> > when there may
> > > be more config files.
> > >
> > > Trying a .zip this time so it doesn't get eaten by the
> list filter.
> > >
> > > //Ma <<Config_editors.zip>> gnus
> > >
> > >
> > >
> > >
> >
>