Re: new heapcheck contrib module
От | Mark Dilger |
---|---|
Тема | Re: new heapcheck contrib module |
Дата | |
Msg-id | E43A0AF5-C8D8-44EB-A2A0-3812D0471A48@enterprisedb.com обсуждение исходный текст |
Ответ на | Re: new heapcheck contrib module (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: new heapcheck contrib module
|
Список | pgsql-hackers |
> On Jan 28, 2021, at 9:13 AM, Robert Haas <robertmhaas@gmail.com> wrote: > > I like 0007 quite a bit and am inclined to commit it soon, as it > doesn't depend on the earlier patches. But: > > - I think the residual comment in processSQLNamePattern beginning with > "Note:" could use some wordsmithing to account for the new structure > of things -- maybe just "this pass" -> "this function". > - I suggest changing initializations like maxbuf = buf + 2 to maxbuf = > &buf[2] for clarity. Ok, I should be able to get you an updated version of 0007 with those changes here soon for you to commit. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: