pgsql: Fix pg_upgrade around multixid and mxoff wraparound

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема pgsql: Fix pg_upgrade around multixid and mxoff wraparound
Дата
Msg-id E1vJ8mr-006E2v-35@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix pg_upgrade around multixid and mxoff wraparound

pg_resetwal didn't accept multixid 0 or multixact offset UINT32_MAX,
but they are both valid values that can appear in the control file.
That caused pg_upgrade to fail if you tried to upgrade a cluster
exactly at multixid or offset wraparound, because pg_upgrade calls
pg_resetwal to restore multixid/offset on the new cluster to the
values from the old cluster. To fix, allow those values in
pg_resetwal.

Fixes bugs #18863 and #18865 reported by Dmitry Kovalenko.

Backpatch down to v15. Version 14 has the same bug, but the patch
doesn't apply cleanly there. It could be made to work but it doesn't
seem worth the effort given how rare it is to hit this problem with
pg_upgrade, and how few people are upgrading to v14 anymore.

Author: Maxim Orlov <orlovmg@gmail.com>
Discussion:
https://www.postgresql.org/message-id/CACG%3DezaApSMTjd%3DM2Sfn5Ucuggd3FG8Z8Qte8Xq9k5-%2BRQis-g@mail.gmail.com
Discussion: https://www.postgresql.org/message-id/18863-72f08858855344a2@postgresql.org
Discussion: https://www.postgresql.org/message-id/18865-d4c66cf35c2a67af@postgresql.org
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/94939c5f3ab0a390e52c0802c7141c42673a48b4

Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c  | 25 +++++++++++++++----------
src/bin/pg_resetwal/t/001_basic.pl | 12 +++++++-----
2 files changed, 22 insertions(+), 15 deletions(-)


В списке pgsql-committers по дате отправления: